Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make List Copy explicit in divide_polynomialcoeff #3706

Merged

Conversation

kevaundray
Copy link
Contributor

Pulled this out of #3697 so that #3697 is primarily adding type casts

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwwhww hwwhww added the EIP-7594 PeerDAS label Apr 22, 2024
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 nice catch.

@kevaundray kevaundray changed the title chore: Remove redundant re-definition in divide_polynomialcoeff chore: Make List Copy explicit in divide_polynomialcoeff Apr 22, 2024
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Using copy() and the comment definitely improve readability here.

@jtraglia jtraglia merged commit e51f7df into ethereum:dev Apr 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EIP-7594 PeerDAS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants