Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add correct type casts to eip7594 functions #3697

Open
wants to merge 26 commits into
base: dev
Choose a base branch
from
Open

chore: Add correct type casts to eip7594 functions #3697

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
8ad8b69
add eip7594 to pylint checks
kevaundray Apr 18, 2024
006cfe6
fix pylint errors
kevaundray Apr 18, 2024
9c9f8f1
temp fix
kevaundray Apr 18, 2024
3554d79
Merge branch 'dev' into pr3697
hwwhww Apr 19, 2024
d5b4e6c
workaround: add a new config `MAX_EXTENDED_MATRIX_SIZE` to avoid `cla…
hwwhww Apr 19, 2024
ec0dc1f
ensure that value is in the correct range
kevaundray Apr 19, 2024
2a49ce2
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 19, 2024
2c32877
fix new lint errors
kevaundray Apr 19, 2024
b031a80
try: adding back line
kevaundray Apr 22, 2024
0dc414b
try: type ignore
kevaundray Apr 22, 2024
864e45a
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 22, 2024
0f8b0b4
add copy
kevaundray Apr 22, 2024
d2a8cb5
fix lint
kevaundray Apr 22, 2024
13d73ff
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 22, 2024
783899c
fix new linter errors
kevaundray Apr 22, 2024
47ef8ff
remove check from CI
kevaundray Apr 22, 2024
ac26ed2
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 23, 2024
31be7bf
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 25, 2024
97ce095
remove extra modulus reduction
kevaundray Apr 25, 2024
62ce140
append and reverse list
kevaundray Apr 25, 2024
8c10508
fix new linter error
kevaundray Apr 25, 2024
e5ad8b7
re-arrange BLS_MODULUS to be before b[i]
kevaundray Apr 25, 2024
1cc7e1a
Avoid underflow
asn-d6 Apr 29, 2024
6eb5756
Correctly handle CosetEvals in compute_cells()
asn-d6 Apr 29, 2024
92b25e6
lint
kevaundray Apr 29, 2024
4de4625
Merge branch 'dev' into kw/add-eip7594-to-pylint
kevaundray Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion specs/_features/eip7594/das-core.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ We define the following Python custom types for type hinting and readability:
| Name | SSZ equivalent | Description |
| - | - | - |
| `DataColumn` | `List[Cell, MAX_BLOB_COMMITMENTS_PER_BLOCK]` | The data of each column in EIP-7594 |
| `ExtendedMatrix` | `List[Cell, MAX_BLOBS_PER_BLOCK * NUMBER_OF_COLUMNS]` | The full data of one-dimensional erasure coding extended blobs (in row major format) |
| `ExtendedMatrix` | `List[Cell]` | The full data of one-dimensional erasure coding extended blobs (in row major format). It's max size is `MAX_BLOBS_PER_BLOCK * NUMBER_OF_COLUMNS`|
kevaundray marked this conversation as resolved.
Show resolved Hide resolved

## Configuration

Expand Down