-
Notifications
You must be signed in to change notification settings - Fork 915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-7547: Inclusion Lists #3617
Open
michaelneuder
wants to merge
38
commits into
ethereum:dev
Choose a base branch
from
michaelneuder:inclusion-lists-03072024
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
7d7398d
add full capella pyspec
michaelneuder 07e713c
dev push for ils changes
michaelneuder eebbd6e
deneb update
michaelneuder fb3d2a3
Merge branch 'dev' of https://github.com/ethereum/consensus-specs int…
michaelneuder ffc3c76
remove old stuff
michaelneuder 01b2f64
init commit
michaelneuder 6984a1a
beacon chain
michaelneuder 6c0c56a
fixes
michaelneuder 42c122d
simplify
michaelneuder c7b1fd1
doctoc .
michaelneuder 2e1b630
simplify
michaelneuder 8114991
naming issue
michaelneuder d04d802
Update specs/_features/eip7547/p2p-networking.md
michaelneuder 6599c32
Update specs/_features/eip7547/p2p-networking.md
michaelneuder 2efaf1a
Update specs/_features/eip7547/p2p-networking.md
michaelneuder a11886c
Update specs/_features/eip7547/p2p-networking.md
michaelneuder d8d45bb
Update specs/_features/eip7547/p2p-networking.md
michaelneuder 8970f6b
validator tweaks
michaelneuder d25b5d6
validate the inclusion list on_block
michaelneuder 38f74d3
fix newline
michaelneuder 90cf263
fix newline
michaelneuder 7cb01ab
s/143/256
michaelneuder 6dc2894
Make linter happy
hwwhww dcb206f
fix typo
hwwhww 335b6b5
beacon-chain.md updates
michaelneuder 995c049
beacon-chain.md updates
michaelneuder 75aa52c
fork-choice.md
michaelneuder 97cc84c
fork-choice.md
michaelneuder f46dd05
p2p-networking.md
michaelneuder 0059893
validator.md
michaelneuder f0a13ab
small fixes
michaelneuder 7545154
terence responses
michaelneuder c00b2d8
verify signature check
michaelneuder c82960d
signed summary in EL block
michaelneuder 4d54445
fc changes
michaelneuder 920fab1
keying on parent_hash too
michaelneuder 086d20b
tweaks
michaelneuder 37ca0c9
fork choice filter
michaelneuder File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work since you may have grand children that are valid
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you make this work by doing the following:
is_inclusion_list_available
here just checks this bool is trueEffectively tracking the latest seen block with an available IL which I think is what we want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't really work because we may have to reorg back to a head for witch we haven't seen an IL. Without reconstructing it we always rely on external sources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this was after or before the Discord discussion, but just in case and to leave it documented, this doesn't work either since you may be turning for true a node where no one has seen the IL except the child's builder. In this case this node should never be taken for head or the EL should be able to reconstruct the IL.