Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ERC-4626: replace old repo link #394

Closed
wants to merge 1 commit into from
Closed

Update ERC-4626: replace old repo link #394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ERCS/erc-4626.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
eip: 4626
title: Tokenized Vaults
description: Tokenized Vaults with a single underlying EIP-20 token.

Check failure on line 4 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[preamble-refs-description]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
 --> ERCS/erc-4626.md:4:56
  |
4 | description: Tokenized Vaults with a single underlying EIP-20 token.
  |                                                        ^^^^^^ referenced here
  |
  = help: see https://ethereum.github.io/eipw/preamble-refs-description/

Check failure on line 4 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

references to proposals with a `category` of `ERC` must use a prefix of `ERC` 

error[preamble-refs-description]: references to proposals with a `category` of `ERC` must use a prefix of `ERC`
 --> ERCS/erc-4626.md:4:56
  |
4 | description: Tokenized Vaults with a single underlying EIP-20 token.
  |                                                        ^^^^^^ referenced here
  |
  = help: see https://ethereum.github.io/eipw/preamble-refs-description/
author: Joey Santoro (@joeysantoro), t11s (@transmissions11), Jet Jadeja (@JetJadeja), Alberto Cuesta Cañada (@alcueca), Señor Doggo (@fubuloubu)
discussions-to: https://ethereum-magicians.org/t/eip-4626-yield-bearing-vault-standard/7900
status: Final
Expand Down Expand Up @@ -576,10 +576,10 @@

## Reference Implementation

See [Solmate EIP-4626](https://github.com/Rari-Capital/solmate/blob/main/src/mixins/ERC4626.sol):
See [Solmate EIP-4626](https://github.com/transmissions11/solmate/blob/main/src/tokens/ERC4626.sol):

Check failure on line 579 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-4626.md
    |
579 | See [Solmate EIP-4626](https://github.com/transmissions11/solmate/blob/main/src/tokens/ERC4626.sol):
    |
    = help: see https://ethereum.github.io/eipw/markdown-rel-links/

Check failure on line 579 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-4626.md
    |
579 | See [Solmate EIP-4626](https://github.com/transmissions11/solmate/blob/main/src/tokens/ERC4626.sol):
    |
    = help: see https://ethereum.github.io/eipw/markdown-rel-links/
a minimal and opinionated implementation of the standard with hooks for developers to easily insert custom logic into deposits and withdrawals.

See [Vyper EIP-4626](https://github.com/fubuloubu/ERC4626):

Check failure on line 582 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-4626.md
    |
582 | See [Vyper EIP-4626](https://github.com/fubuloubu/ERC4626):
    |

Check failure on line 582 in ERCS/erc-4626.md

View workflow job for this annotation

GitHub Actions / EIP Walidator

non-relative link or image 

error[markdown-rel-links]: non-relative link or image
   --> ERCS/erc-4626.md
    |
582 | See [Vyper EIP-4626](https://github.com/fubuloubu/ERC4626):
    |
a demo implementation of the standard in Vyper, with hooks for share price manipulation and other testing needs.

## Security Considerations
Expand Down