Add EIP: Separate gas type for calldata #8552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-new
|
✅ All reviewers have approved. |
eth-bot
added
e-consensus
eth-bot
changed the title
|
The commit 513d424 (as a parent of 5ea7da6) contains errors. |
abcoathup
reviewed
May 14, 2024
abcoathup
reviewed
May 14, 2024
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
Co-authored-by: Andrew B Coathup <28278242+abcoathup@users.noreply.github.com>
19 tasks
etan-status
reviewed
May 16, 2024
Co-authored-by: Etan Kissling <etan@status.im>
12 tasks
g11tech
approved these changes
May 28, 2024
eth-bot
approved these changes
May 28, 2024
VersoriumX
reviewed
May 29, 2024
| @@ -63,7 +63,7 @@ def get_max_fees(tx: Transaction) -> [int, int, int]: | |||
| elif tx.type == BLOB_TX_TYPE: | |||
| return [tx.max_fee_per_gas, tx.max_fee_per_blob_gas, tx.max_fee_per_gas] | |||
| elif is_eip_1559(tx.type): | |||
| return [tx.max_fee_per_gas, 0, max_fee_per_gas] | |||
There was a problem hiding this comment.
commit 9eb41928548665e15617b27d258ac13379390acc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new type of gas for transaction calldata. Add a new transaction type that provides max_basefee and priority_fee as a vector, providing values for execution gas, blob gas and calldata gas. Modify EIP-1559 to use the same mechanism for the three types of gas.