Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EIP-1474: Update eip-1474.md Fixing the net_version usage example (adding missed comma and deleting the excess onse) #8537

Merged
merged 1 commit into from
May 22, 2024

Conversation

Ro4mer
Copy link
Contributor

@Ro4mer Ro4mer commented May 8, 2024

Adding some commas to the net_version usage example

ATTENTION: ERC-RELATED PULL REQUESTS NOW OCCUR IN ETHEREUM/ERCS

--

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

Adding some commas to the net_version usage example
@Ro4mer Ro4mer requested a review from eth-bot as a code owner May 8, 2024 20:36
@github-actions github-actions bot added c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-interface labels May 8, 2024
@eth-bot
Copy link
Collaborator

eth-bot commented May 8, 2024

File EIPS/eip-1474.md

Requires 1 more reviewers from @rekmarks
Requires 1 more reviewers from @axic, @lightclient, @SamWilsn

@eth-bot eth-bot added the a-review Waiting on author to review label May 8, 2024
@eth-bot eth-bot changed the title Update eip-1474.md Fixing the net_version usage example (adding missed comma and deleting the excess onse) Update EIP-1474: Update eip-1474.md Fixing the net_version usage example (adding missed comma and deleting the excess onse) May 8, 2024
Copy link

github-actions bot commented May 8, 2024

The commit 1409208 (as a parent of c259693) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci Waiting on CI to pass label May 8, 2024
@SamWilsn SamWilsn merged commit 1ee0086 into ethereum:master May 22, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-review Waiting on author to review c-update Modifies an existing proposal s-stagnant This EIP is Stagnant t-interface w-ci Waiting on CI to pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants