Merge pull request #1597 from ethereum-optimism/fix/batch-submitter-e…

…rr-msg batch-submitter: handle error case explicitly
ethereum-optimism · Oct 18, 2021 · 7bd42d9 · 7bd42d9
2 parents 7c05692 + ce03037
commit 7bd42d9
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/great-buckets-bow.md b/.changeset/great-buckets-bow.md
@@ -0,0 +1,5 @@
+---
+'@eth-optimism/batch-submitter': patch
+---
+
+Handle error case more explicity when creating invalid batch
diff --git a/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts b/packages/batch-submitter/src/batch-submitter/tx-batch-submitter.ts
@@ -195,8 +195,12 @@ export class TransactionBatchSubmitter extends BatchSubmitter {
       return
     }
 
-    const [batchParams, wasBatchTruncated] =
-      await this._generateSequencerBatchParams(startBlock, endBlock)
+    const params = await this._generateSequencerBatchParams(startBlock, endBlock)
+    if (!params) {
+      throw new Error(`Cannot create sequencer batch with params start ${startBlock} and end ${endBlock}`)
+    }
+
+    const [batchParams, wasBatchTruncated] = params
     const batchSizeInBytes = encodeAppendSequencerBatch(batchParams).length / 2
     this.logger.debug('Sequencer batch generated', {
       batchSizeInBytes,