Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: eejs update to support latest ejs #4751

Closed
wants to merge 1 commit into from
Closed

Conversation

JohnMcLear
Copy link
Member

@JohnMcLear JohnMcLear commented Feb 11, 2021

This patch will mean that plugins source wont render :(

@webzwo0i
Copy link
Member

because of mde/ejs#470
__output is no array anymore. however, I tried to convert the code to work with a string (slice instead of splice, no join, += instead of push etc) but it does not work. weird

@JohnMcLear
Copy link
Member Author

yea I tried the same ;(

@webzwo0i
Copy link
Member

Giving it another try now. The problem is we need access to that (internal) variable, probably for our custom begin/end blocks. If it's not working, we should better understand the security issue (I don't completely understand this atm): I don't think we're using user-generated render/filenames or if we do, we can sanitize it ourselves.

Because you asked regarding replacing ejs: I do not have this on my agenda for new packaging, as I hope there will be a working loader.

@JohnMcLear JohnMcLear closed this Feb 14, 2021
@rhansen rhansen deleted the ejs-update branch February 15, 2021 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants