Skip to content

Commit

Permalink
tests: Pass --legacy-peer-deps with npm >= 7.x
Browse files Browse the repository at this point in the history
This works around npm/cli#2199.
  • Loading branch information
rhansen committed Feb 16, 2021
1 parent a550d2f commit 7f8d3bb
Show file tree
Hide file tree
Showing 4 changed files with 17 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .github/workflows/backend-tests.yml
Expand Up @@ -59,7 +59,10 @@ jobs:
- name: Install Etherpad plugins
run: >
npm install
npm_version=$(npm --version) || exit 1;
npm_major=${npm_version%%.*};
flags=; [ $npm_major -lt 7 ] || flags=--legacy-peer-deps;
npm install $flags
ep_align
ep_author_hover
ep_cursortrace
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/frontend-admin-tests.yml
Expand Up @@ -28,7 +28,11 @@ jobs:

# We intentionally install a much old ep_align version to test update minor versions
- name: Install etherpad plugins
run: npm install ep_align@0.2.27
run: >
npm_version=$(npm --version) || exit 1;
npm_major=${npm_version%%.*};
flags=; [ $npm_major -lt 7 ] || flags=--legacy-peer-deps;
npm install $flags ep_align@0.2.27
# Nuke plugin tests
- name: Install etherpad plugins
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/frontend-tests.yml
Expand Up @@ -65,7 +65,10 @@ jobs:

- name: Install Etherpad plugins
run: >
npm install
npm_version=$(npm --version) || exit 1;
npm_major=${npm_version%%.*};
flags=; [ $npm_major -lt 7 ] || flags=--legacy-peer-deps;
npm install $flags
ep_align
ep_author_hover
ep_cursortrace
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/load-test.yml
Expand Up @@ -52,7 +52,10 @@ jobs:

- name: Install etherpad plugins
run: >
npm install
npm_version=$(npm --version) || exit 1;
npm_major=${npm_version%%.*};
flags=; [ $npm_major -lt 7 ] || flags=--legacy-peer-deps;
npm install $flags
ep_align
ep_author_hover
ep_cursortrace
Expand Down

0 comments on commit 7f8d3bb

Please sign in to comment.