Multicall3 (work in progress) #1468
Open
+955
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we copy instead of deepcopy, then when the network name is overwritten with the RPC url, later calls do not set "explorer" or "chain_id" (since line 87 is looking for names and not RPCs). Without this change, the `active_network` config is missing: `, 'chainid': '1', 'explorer': 'https://api.etherscan.io/api'}` ``` >>> print(CONFIG.active_network) {'name': 'Hardhat (Mainnet Fork)', 'id': 'hardhat-fork', 'cmd': 'npx hardhat node', 'host': 'http://127.0.0.1', 'multicall2': '0x5BA1e12693Dc8F9c48aAD8770482f4739bEeD696', 'cmd_settings': {'port': 8545, 'fork': 'https://turbo-eth.stytt.com/', 'chain_id': 1}, 'settings': {'gas_limit': 'max', 'gas_buffer': 1, 'gas_price': 0, 'max_fee': None, 'priority_fee': None, 'reverting_tx_gas_limit': 'max', 'default_contract_owner': True, 'cmd_settings': None}, 'chainid': '1', 'explorer': 'https://api.etherscan.io/api'} >>> network.disconnect() Terminating local RPC client... >>> network.connect("hardhat-fork") Launching 'npx hardhat node --port 8545 --fork https://turbo-eth.stytt.com/'... >>> print(CONFIG.active_network) {'name': 'Hardhat (Mainnet Fork)', 'id': 'hardhat-fork', 'cmd': 'npx hardhat node', 'host': 'http://127.0.0.1', 'multicall2': '0x5BA1e12693Dc8F9c48aAD8770482f4739bEeD696', 'cmd_settings': {'port': 8545, 'fork': 'https://turbo-eth.stytt.com/', 'chain_id': 1}, 'settings': {'gas_limit': 'max', 'gas_buffer': 1, 'gas_price': 0, 'max_fee': None, 'priority_fee': None, 'reverting_tx_gas_limit': 'max', 'default_contract_owner': True, 'cmd_settings': None}, 'chainid': '1', 'explorer': 'https://api.etherscan.io/api'} ```
|
this has patch-3 and a fix for Contract.init merged into it because I need those fixes to test my script that uses this code. We can merge them all separately if you'd prefer. |
This reverts commit be1ff04.
VersoriumX
approved these changes
May 4, 2024
VersoriumX
approved these changes
May 4, 2024
VersoriumX
approved these changes
May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Make Multicall a bit more robust and added support for Multicall3
How I did it
Modified multicall.py
How to verify it
Use the multicall helper on any chain and any block.
Checklist