Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

545: Move to JUnit5 #547

Merged
merged 1 commit into from
Mar 26, 2019
Merged

545: Move to JUnit5 #547

merged 1 commit into from
Mar 26, 2019

Conversation

yb172
Copy link
Contributor

@yb172 yb172 commented Mar 24, 2019 •
edited

all: move to JUnit5

Move tests to JUnit5

Fixes #545

@yb172 yb172 mentioned this pull request Mar 24, 2019
Closed
@yb172 yb172 mentioned this pull request Mar 25, 2019
Closed
@yb172 yb172 force-pushed the 545/junit-5 branch 3 times, most recently from a03613e to c7dc712 Compare March 25, 2019 04:20
@yb172 yb172 changed the title WIP: 545: Move to JUnit5 545: Move to JUnit5 Mar 25, 2019
@yb172
Copy link
Contributor Author

yb172 commented Mar 25, 2019

As discussed offline - removed assertTimeoutPreemptively (would rely on CI timeout instead). #548 filed to address that later.
Also #549 filed to address GrpcServerRule and move to JUnit5 completely.
@fanminshi please take a look.

fanminshi
fanminshi reviewed Mar 25, 2019
View reviewed changes
jetcd-core/src/test/java/io/etcd/jetcd/SslTest.java Outdated Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/SslTest.java Outdated Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/KVTest.java Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/LeaseUnitTest.java Outdated Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/LoadBalancerTest.java Outdated Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/MaintenanceTest.java Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/LockTest.java Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/WatchTest.java Show resolved Hide resolved
jetcd-core/src/test/java/io/etcd/jetcd/WatchUnitTest.java Outdated Show resolved Hide resolved
jetcd-launcher/src/main/java/io/etcd/jetcd/launcher/junit4/EtcdClusterResource.java Show resolved Hide resolved
@fanminshi
Copy link
Member

@yb172 I noticed that your changes include modify indent spacing. Could you check why that's the case? it might be your IDE setting. i think it should be 2 spaces according the google java style sheet here https://google.github.io/styleguide/javaguide.html#s4.2-block-indentation.

@fanminshi
Copy link
Member

Overall, it looks good!

@yb172 yb172 force-pushed the 545/junit-5 branch 3 times, most recently from c80ee54 to f6cf986 Compare March 25, 2019 05:47
@yb172 yb172 mentioned this pull request Mar 25, 2019
Closed
@fanminshi
Copy link
Member

lgtm after not adding extra 2 spaces from WatchUnitTest.java

@yb172 yb172 force-pushed the 545/junit-5 branch 2 times, most recently from cb0acfd to a6e7327 Compare March 25, 2019 08:13
@yb172
all: move to JUnit5
f961e96 
Move tests to JUnit5

Fixes etcd-io#545
@fanminshi
Copy link
Member

lgtm

@fanminshi fanminshi merged commit 907b8c4 into etcd-io:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanminshi fanminshi fanminshi left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yb172 @fanminshi