Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watcher: Expose isClosed method #1360

Merged
merged 1 commit into from
May 14, 2024
Merged

watcher: Expose isClosed method #1360

merged 1 commit into from
May 14, 2024

Conversation

giri-vsr
Copy link
Contributor

Expose isClosed method on watcher so that we can restart the watch incase it is closed because of Errors.isHaltError(status) or Errors.isNoLeaderError(status)

@giri-vsr
Copy link
Contributor Author

@lburgazzoli can you please check this?

@lburgazzoli
Copy link
Collaborator

@giri-vsr it would be nice to add a test

Signed-off-by: Giri Ramasamy <46867712+giri-vsr@users.noreply.github.com>
@giri-vsr
Copy link
Contributor Author

@lburgazzoli Thanks. Test and method already exists. Just exposing isClosed method.

Now I have updated the test to access isClosed without casting
https://github.com/etcd-io/jetcd/pull/1360/files#diff-5f89a9932256c4646613add04e2b8bd044b71bdd11394f1df0e574fe740015e2

@giri-vsr
Copy link
Contributor Author

@lburgazzoli anything else required? Also is it possible to do a release after this is merged? Thanks

@lburgazzoli lburgazzoli merged commit 6d375c8 into etcd-io:main May 14, 2024
9 checks passed
@lburgazzoli
Copy link
Collaborator

@giri-vsr I'll try to do a release this week

@giri-vsr
Copy link
Contributor Author

Thanks

@giri-vsr
Copy link
Contributor Author

@lburgazzoli Did you manage to do the release?

@lburgazzoli
Copy link
Collaborator

no, will do this week. sorry for the delay

@giri-vsr
Copy link
Contributor Author

@lburgazzoli No worries.Let me know once it is released Thanks

@giri-vsr
Copy link
Contributor Author

@lburgazzoli Did you manage to do the release?

@lburgazzoli
Copy link
Collaborator

@giri-vsr trying to release, but having issues with nexus/maven central

@lburgazzoli
Copy link
Collaborator

0.8.2 should be synced to maven central soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants