Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish etcd test rule and extension #546

Closed
yb172 opened this issue Mar 23, 2019 · 2 comments
Closed

Publish etcd test rule and extension #546

yb172 opened this issue Mar 23, 2019 · 2 comments
Labels

Comments

@yb172
Copy link
Contributor

yb172 commented Mar 23, 2019

I was looking at #545 and the way to port existing EtdClusterResource to JUnit5 extension and found this page: https://github.com/junit-team/junit5/wiki/Third-party-Extensions.
I though it could be nice to package existing JUnit4 rule (and hopefully JUnit5 extension) as a jar so anyone who is using etcd could easily use it for their integration tests.

I've looked at maven artifacts and it doesn't look like it's published: https://mvnrepository.com/artifact/com.coreos (though examples and watch example are published...)

@fanminshi @lburgazzoli what do you think?

@fanminshi
Copy link
Member

fanminshi commented Mar 23, 2019

@yb172 that's sounds like a good idea. I think it is not too hard to publish the snapshot which is published after every pr merges as seen from this link https://oss.sonatype.org/content/repositories/snapshots/io/etcd/. You might need to play with pom to get that works. However, publish an official release including this test-extension to https://mvnrepository.com/artifact/io.etcd might need to wait until we do a 0.4.0 release since it is done manually and I think only @lburgazzoli can do it for now.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity.
Remove stale label or comment or this will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants