Add integration tests for gofail #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
7805958
to
577c5e3
Compare
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
4 times, most recently
from
8195e54
to
fd562c1
Compare
henrybear327
changed the title
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
fd562c1
to
c0dea6d
Compare
|
/cc @ahrtr the code here is now rebased! |
|
Please take a look & fix the workflow failure. |
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
4 times, most recently
from
b2652ba
to
f3490e0
Compare
ahrtr
reviewed
May 22, 2024
|
cc @ArkaSaha30 PTAL |
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com> Co-authored-by: Benjamin Wang <benjamin.wang@broadcom.com>
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
b79fe8a
to
9f57df4
Compare
Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
henrybear327
force-pushed
the
improvement/Execution-of-failpoint-should-not-block-deactivation_integration_test
branch
from
7f17e8b
to
7ca32e4
Compare
ahrtr
reviewed
May 23, 2024
Comment on lines
+1
to
+20
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| GOFAIL_BINARY="$(pwd)/gofail" | ||
|
|
||
| cd $(dirname $0) | ||
|
|
||
| pushd failpoints | ||
| $GOFAIL_BINARY enable | ||
| popd | ||
|
|
||
| go build -o integration_test_sleep . | ||
|
|
||
| pushd failpoints | ||
| $GOFAIL_BINARY disable | ||
| popd | ||
|
|
||
| ./integration_test_sleep | ||
| rm integration_test_sleep |
There was a problem hiding this comment.
Suggest to follow https://github.com/etcd-io/etcd/blob/main/tests/robustness/makefile.mk to get most of the work included in a makefile.mk included in integration
There was a problem hiding this comment.
I will try to follow the Makefile style in the Robustness test and replicate it here! :)
ArkaSaha30
suggested changes
May 23, 2024
| - uses: actions/checkout@v4 | ||
| - name: tests | ||
| run: | | ||
| make run-integration-test |
There was a problem hiding this comment.
As per makefile it should be make run-all-integration-test
There was a problem hiding this comment.
Oops, thanks ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add integration test for the gofail library.
The idea is to make sure features, such as the one introduced in #65 will not have regression in future changes.