Robustness operations failpoints #17889
Conversation
serathius
force-pushed
the
robustness-operations-failpoints
branch
from
d884401
to
9e11172
Compare
tests/client/client.go
Outdated
| @@ -12,7 +12,7 @@ | |||
| // See the License for the specific language governing permissions and | |||
| // limitations under the License. | |||
|
|
|||
| package traffic | |||
| package client | |||
There was a problem hiding this comment.
why moving the client out of robustness? Is it useful for other tests?
There was a problem hiding this comment.
Ups, I meant to move it to tests/robustness/client
| ) | ||
|
|
||
| type trigger interface { | ||
| Trigger(ctx context.Context, t *testing.T, member e2e.EtcdProcess, clus *e2e.EtcdProcessCluster) error | ||
| Trigger(ctx context.Context, t *testing.T, member e2e.EtcdProcess, clus *e2e.EtcdProcessCluster, baseTime time.Time, ids identity.Provider) ([]report.ClientReport, error) |
There was a problem hiding this comment.
Can you add some comments about when the trigger should return the clientReport? Most of the time it seems to be nil.
There was a problem hiding this comment.
When it makes a request using recording client.
serathius
force-pushed
the
robustness-operations-failpoints
branch
from
9e11172
to
52fac15
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
robustness-operations-failpoints
branch
from
52fac15
to
c4e3b61
Compare
|
/retest |
| func (c *RecordingClient) Endpoints() []string { | ||
| return c.client.Endpoints() | ||
| } |
There was a problem hiding this comment.
I'm just curious when we lock and when we don't, also in the places we are using the kvMux, we aren't appending operations unless I'm missing something. Or are we making this change proactively for some work in the future?
There was a problem hiding this comment.
We lock when we are making a call to etcd, because linearization requires that there are no concurrent operations sharing the same clientID.
cc @fuweid @siyuanfoundation @MadhavJivrajani