e2e test: add schema version verification in mix_version_test. #17881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
506450d
to
e899f7c
Compare
serathius
reviewed
Apr 26, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
e899f7c
to
252d6d9
Compare
|
/retest |
serathius
reviewed
Apr 27, 2024
serathius
approved these changes
Apr 27, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
252d6d9
to
e21756b
Compare
|
cc @ahrtr |
|
/retest |
ahrtr
reviewed
Apr 29, 2024
ahrtr
reviewed
Apr 29, 2024
siyuanfoundation
force-pushed
the
downgrade-snap
branch
4 times, most recently
from
b7f6a39
to
bad484f
Compare
ahrtr
reviewed
Apr 30, 2024
|
The existing schemaChanges isn't flexible. Propose to add the following changes, and we can construct the the |
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
bad484f
to
892abc2
Compare
|
cc @serathius to take a look |
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Signed-off-by: Siyuan Zhang <sizhang@google.com>
siyuanfoundation
force-pushed
the
downgrade-snap
branch
from
892abc2
to
56fab21
Compare
serathius
reviewed
May 9, 2024
| if newFields, found := newFieldsMapping[v]; found { | ||
| return newFields | ||
| } | ||
| return nil |
There was a problem hiding this comment.
Should panic/error if user calls with invalid version.
serathius
reviewed
May 9, 2024
| }, | ||
| } | ||
| // schemaChanges list changes that were introduced in a particular version. | ||
| // schema was introduced in v3.6 as so its changes were not tracked before. | ||
| schemaChanges = newFieldMappingsToSchemaChanges(newFieldsMapping) |
There was a problem hiding this comment.
Don't like this change, it limits the possible schema changes to just adding new empty fields.
serathius
reviewed
May 9, 2024
| } | ||
| lg.Info("verify no new storage schema field is present in the db file of last release process") | ||
| nextEtcdVer := semver.Version{Major: currentEtcdVer.Major, Minor: currentEtcdVer.Minor + 1} | ||
| newFields := schema.NewFieldsForVersion(nextEtcdVer) |
There was a problem hiding this comment.
Validating consistency of schema should be a feature of schema package. Same as bbolt consistency check, schema should be able to confirm that fields presents and their values are consistent with storage version value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17361
#17752
Verify storage version is consistent with expected at the end of tests.
Since
storageVersionis the only field added in 3.6, there is no need to check other buckets.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.