[3.5] fix revision loss issue caused by compaction - 17780 #17865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 7173391) Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com> (cherry picked from commit 9ea2349) Signed-off-by: Wei Fu <fuweid89@gmail.com>
Signed-off-by: Wei Fu <fuweid89@gmail.com>
fuweid
commented
Apr 24, 2024
| // NOTE: The proc panics and exit code is 2. It's impossible to restart | ||
| // that etcd proc because last exit code is 2 and Restart() refuses to | ||
| // start new one. Using IsRunning() function is to cleanup status. | ||
| require.False(t, clus.Procs[targetIdx].IsRunning()) |
There was a problem hiding this comment.
Side note:
// The proc panics and exit code is 2. It's impossible to restart
// that etcd proc because last exit code is 2 and Restart() refuses to
// start new one. Using IsRunning() function is to cleanup status.
There was a problem hiding this comment.
I think we might be missing some improvements to expect on release-3.5 branch. As a testing library change, we could consider backporting them avoid need for branch specific test code code causing branches to diverge.
There was a problem hiding this comment.
+1 to make the test as consistent as possible. @fuweid can you please raise a followup to track it? thanks
6 tasks
serathius
approved these changes
Apr 24, 2024
ahrtr
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.