[release-3.4] backport fix watch event loss after compaction #17555 #17610
+70
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
changed the title
Merged
fuweid
approved these changes
Mar 19, 2024
serathius
approved these changes
Mar 19, 2024
chaochn47
deleted the
backport-3.4-fix-watch-event-loss-after-compaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
There seems no go failpoint enabled integration tests. Is it okay just backporting the fix and unit test? Adding an e2e test with go failpoint should be feasible. Let me know if this is the requirement of backporting the fix.
xref. #17529