Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 15877 and bump up gRPC from v1.52.0 to v1.57.0 #16338

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

chaochn47
Copy link
Member

@chaochn47 chaochn47 commented Jul 31, 2023

Fix #16290

Pending to evaluate potential breaking changes mentioned in #15145 (comment).

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@chaochn47
Copy link
Member Author

chaochn47 commented Jul 31, 2023

One flaky robustness test execution with LazyFS link. Retry should help.

traffic.go:106: Requiring minimal 100.000000 qps for test results to be reliable, got 99.438205 qps

Signed-off-by: Chao Chen <chaochn@amazon.com>
@ahrtr
Copy link
Member

ahrtr commented Aug 1, 2023

This PR seems to be almost identical to #16301

@liggitt
Copy link
Contributor

liggitt commented Aug 1, 2023

This PR seems to be almost identical to #16301

this picks up the genproto version I cared about, so if it's passing presubmits (#16301 is hitting a weird timeout), I'm happy to see this merge instead

@chaochn47
Copy link
Member Author

Pending to evaluate potential breaking changes mentioned in #15145 (comment).

I have reviewed merged changes especially grpc/grpc-go#6471 and grpc/grpc-go#6481. Those should be backward compatible changes until grpc-go completely remove the deprecated API like resolver.State.Addresses. It will be obvious that etcd cannot compile since the symbols will be removed and captured by the CI.

this picks up the genproto version I cared about, so if it's passing presubmits (#16301 is hitting a weird timeout), I'm happy to see this merge instead

Thanks, I will mark the PR as ready to review with the above two arguments.

@chaochn47 chaochn47 marked this pull request as ready for review August 2, 2023 04:58
@wenjiaswe
Copy link
Contributor

lgtm

@ahrtr
Copy link
Member

ahrtr commented Aug 2, 2023

I have reviewed merged changes especially grpc/grpc-go#6471 and grpc/grpc-go#6481. Those should be backward compatible changes until grpc-go completely remove the deprecated API like resolver.State.Addresses.

Confirmed. We still need to remove the dependency on the experimental gRPC API, as tracked in #15145. Let's continue the discussion in that issue separately.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx @chaochn47

@ahrtr ahrtr merged commit eb04f3a into etcd-io:main Aug 2, 2023
27 checks passed
@chaochn47 chaochn47 deleted the bump-up-grpc branch August 2, 2023 07:39
chaochn47 added a commit to chaochn47/etcd that referenced this pull request Oct 17, 2023
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5

This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5.

Signed-off-by: Chao Chen <chaochn@amazon.com>
dusk125 pushed a commit to dusk125/etcd that referenced this pull request Oct 18, 2023
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5

This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5.

Signed-off-by: Chao Chen <chaochn@amazon.com>
dusk125 pushed a commit to dusk125/etcd that referenced this pull request Oct 18, 2023
The last step with gRPC update behavior changes auditing to resolve CVE etcd-io#16740 in 3.5

This PR backports etcd-io#14922, etcd-io#16338, etcd-io#16587, etcd-io#16630, etcd-io#16636 and etcd-io#16739 to release-3.5.

Signed-off-by: Chao Chen <chaochn@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Dependency: bump gRPC
5 participants