Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] clientv3: do not refresh token when users use CommonName based authentication #14790

Merged
merged 3 commits into from Nov 17, 2022
Merged

[3.5] clientv3: do not refresh token when users use CommonName based authentication #14790

merged 3 commits into from Nov 17, 2022

Commits on Nov 16, 2022

  1. clientv3: do not refresh token when using TLS CommonName based authen… 

    …tication

When users use the TLS CommonName based authentication, the
authTokenBundle is always nil. But it's possible for the clients
to get `rpctypes.ErrAuthOldRevision` response when the clients
concurrently modify auth data (e.g, addUser, deleteUser etc.).
In this case, there is no need to refresh the token; instead the
clients just need to retry the operations (e.g. Put, Delete etc).

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Nov 16, 2022
    Copy the full SHA
    69aace2 View commit details
    Browse the repository at this point in the history

  2. test: add certificate with root CommonName 

    Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Nov 16, 2022
    Copy the full SHA
    9849fa7 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2022

  1. test: add test case to cover the CommonName based authentication 

    Refer to etcd-io#14764

Signed-off-by: Benjamin Wang <wachao@vmware.com>
    @ahrtr
    ahrtr committed Nov 17, 2022
    Copy the full SHA
    4097c24 View commit details
    Browse the repository at this point in the history