Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.4] clientv3: filter learners members during autosync #14236

Merged
merged 1 commit into from Jul 20, 2022

Conversation

chrisayoub
Copy link
Contributor

This change is to ensure that all members returned during the client's
AutoSync are started and are not learners, which are not valid
etcd members to make requests to.

Backport of my previous PRs:
#13837
#13917

Related to: #14232

cc @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Jul 19, 2022

Thank you @chrisayoub , please signoff the commit,

git commit --signoff --amend

@ahrtr ahrtr mentioned this pull request Jul 19, 2022
25 tasks
This change is to ensure that all members returned during the client's
AutoSync are started and are not learners, which are not valid
etcd members to make requests to.

Signed-off-by: Chris Ayoub <cayoub@hubspot.com>
@chrisayoub
Copy link
Contributor Author

@ahrtr done!

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr
Copy link
Member

ahrtr commented Jul 20, 2022

This should be minor and safe change, so merging it.

@ahrtr ahrtr merged commit b0e1aae into etcd-io:release-3.4 Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants