Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-3.4: updated test workflow go version to 1.16 #14134

Closed
wants to merge 7 commits into from

Conversation

lavacat
Copy link

@lavacat lavacat commented Jun 18, 2022

No description provided.

Bogdan Kanivets added 7 commits June 17, 2022 10:38
need newer version of bolt db for go1.16 compatibilty
PASSES='fmt bom dep' ./test

auth/store.go:35:2: missing go.sum entry for module providing package golang.org/x/crypto/bcrypt (imported by go.etcd.io/etcd/auth); to add:
	go get go.etcd.io/etcd/auth
/Users/bk/.gvm/pkgsets/go1.16.7/global/pkg/mod/github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0/client_metrics.go:7:2: missing go.sum entry for module providing package golang.org/x/net/context (imported by go.etcd.io/etcd/etcdserver/etcdserverpb); to add:
	go get go.etcd.io/etcd/etcdserver/etcdserverpb
/Users/bk/.gvm/pkgsets/go1.16.7/global/pkg/mod/google.golang.org/grpc@v1.26.0/internal/transport/controlbuf.go:28:2: missing go.sum entry for module providing package golang.org/x/net/http2 (imported by go.etcd.io/etcd/proxy/httpproxy); to add:
	go get go.etcd.io/etcd/proxy/httpproxy
/Users/bk/.gvm/pkgsets/go1.16.7/global/pkg/mod/google.golang.org/grpc@v1.26.0/internal/transport/controlbuf.go:29:2: missing go.sum entry for module providing package golang.org/x/net/http2/hpack (imported by github.com/soheilhy/cmux); to add:
	go get github.com/soheilhy/cmux@v0.1.4
/Users/bk/.gvm/pkgsets/go1.16.7/global/pkg/mod/google.golang.org/grpc@v1.26.0/server.go:36:2: missing go.sum entry for module providing package golang.org/x/net/trace (imported by go.etcd.io/etcd/embed); to add:
	go get go.etcd.io/etcd/embed
@lavacat lavacat marked this pull request as draft June 18, 2022 01:44
@lavacat
Copy link
Author

lavacat commented Jun 18, 2022

I wasn't able to get a clean run of integration tests locally, there issues seams to be around watches and leases.
There were a lot of updates to test stability in 3.5, so it's not easy to back port those changes.

@ahrtr
Copy link
Member

ahrtr commented Jun 22, 2022

The release of 3.4.19 is a priority to me now, but the first step is to make the pipeline green. But there are still some flaky failures, so the pipeline and test failures are still our top priority.

If you or someone else has difficult on something, my generic suggestion is to either have a deep dive to get it resolved, or break down the PR to get the easier ones fixed firstly and do it step by step.

If the task is a priority to me, then I may jump in to get it resolved by helping the contributor or fixing it myself.

I was trying to help you to resolve this, but I did not do it because:

  1. The number of failure in your PR is even more than the head of 3.4.
  2. I realized that the 3.4 pipeline has never green since its first day, so it's really serious to me.

Sorry for the confusion. I will raise an issue to clearly state the plan for 3.4.19 on top of your issue 14105 or just add comments in your issue. Please feel free to continue to work on 3.4 per the plan by then. Thanks.

@lavacat
Copy link
Author

lavacat commented Jun 22, 2022

@ahrtr no problem. I should have clearly state that it's WIP. I wasn't giving up on it, just wanted to provide some update.

Either new issue or comment in #14105 is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants