Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-3.5]: Update client_golang dependency to v1.11.0 #13092

Merged
merged 1 commit into from Jun 8, 2021

Conversation

lilic
Copy link
Contributor

@lilic lilic commented Jun 7, 2021

See #13091

cc @ptabor @serathius @hexfusion please take a look, thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #13092 (9fee8bf) into release-3.5 (e721e4e) will increase coverage by 13.00%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release-3.5   #13092       +/-   ##
================================================
+ Coverage        49.25%   62.25%   +13.00%     
================================================
  Files              435      421       -14     
  Lines            33993    33560      -433     
================================================
+ Hits             16743    20893     +4150     
+ Misses           15346    10538     -4808     
- Partials          1904     2129      +225     
Flag Coverage Δ
all 62.25% <ø> (+13.00%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
raft/quorum/quorum.go 0.00% <0.00%> (-100.00%) ⬇️
raft/tracker/state.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/tlsutil/cipher_suites.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/sockopt_unix.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/timeout_dialer.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/transport/timeout_listener.go 0.00% <0.00%> (-100.00%) ⬇️
client/pkg/v3/srv/srv.go 0.00% <0.00%> (-89.42%) ⬇️
client/pkg/v3/transport/keepalive_listener.go 0.00% <0.00%> (-84.62%) ⬇️
client/pkg/v3/types/set.go 11.00% <0.00%> (-82.00%) ⬇️
client/pkg/v3/transport/sockopt.go 11.76% <0.00%> (-70.59%) ⬇️
... and 243 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e721e4e...9fee8bf. Read the comment docs.

@hexfusion
Copy link
Contributor

Thanks @lilic! This generally makes sense to stay current is the api change in 1.7[1] anything we need to worry about? Otherwise LGTM.

[1]https://github.com/prometheus/client_golang/releases/tag/v1.7.0

@hexfusion
Copy link
Contributor

hexfusion commented Jun 8, 2021

didn't find a hit on LabelValues or LabelNames directly in the code base so I think we are clear as the change is client side.

@hexfusion hexfusion merged commit b327edf into etcd-io:release-3.5 Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants