Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update gRPC Go to v1.26.0 #11522

Merged
merged 1 commit into from Jan 16, 2020
Merged

Conversation

YoyinZyc
Copy link
Contributor

for #11519

@YoyinZyc YoyinZyc requested a review from jpbetz January 15, 2020 19:16
@codecov-io
Copy link

Codecov Report

Merging #11522 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11522      +/-   ##
==========================================
+ Coverage   64.39%   64.44%   +0.05%     
==========================================
  Files         403      403              
  Lines       38088    38088              
==========================================
+ Hits        24525    24547      +22     
+ Misses      11924    11901      -23     
- Partials     1639     1640       +1
Impacted Files Coverage Δ
clientv3/namespace/watch.go 87.87% <0%> (-6.07%) ⬇️
etcdserver/api/v3rpc/lease.go 69.31% <0%> (-5.69%) ⬇️
clientv3/concurrency/mutex.go 62.16% <0%> (-5.41%) ⬇️
etcdserver/api/v3rpc/watch.go 78.43% <0%> (-2.29%) ⬇️
mvcc/watchable_store.go 83.21% <0%> (-2.1%) ⬇️
etcdserver/api/rafthttp/peer.go 77.65% <0%> (-1.12%) ⬇️
etcdserver/cluster_util.go 56.52% <0%> (-0.8%) ⬇️
clientv3/leasing/kv.go 89.7% <0%> (-0.67%) ⬇️
etcdserver/server.go 66.81% <0%> (-0.07%) ⬇️
clientv3/watch.go 89.77% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af131b5...d7d0824. Read the comment docs.

@xiang90
Copy link
Contributor

xiang90 commented Jan 15, 2020

lgtm

1 similar comment
@jpbetz
Copy link
Contributor

jpbetz commented Jan 15, 2020

lgtm

@xiang90 xiang90 merged commit 67bf39b into etcd-io:master Jan 16, 2020
@xiang90
Copy link
Contributor

xiang90 commented Jan 16, 2020

@YoyinZyc change log needs to be updated.

@@ -25,83 +25,37 @@ import (
"google.golang.org/grpc/balancer"
"google.golang.org/grpc/connectivity"
"google.golang.org/grpc/grpclog"
"google.golang.org/grpc/internal/buffer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoyinZyc hi, I was looking at the couple of issue #11532 and #11529
and I think that these issues are might be because of https://github.com/etcd-io/etcd/tree/master/vendor/google.golang.org/grpc/internal doesn't have the referenced internal/buffer package. The https://github.com/grpc/grpc-go/tree/master/internal has it there. I haven't worked on updating etcd vendor files before but I believe having vendor dir updated with grpc-go master buffer should fix it. Please let me know what you think? Thanks!

"google.golang.org/grpc/serviceconfig"
"google.golang.org/grpc/status"

_ "google.golang.org/grpc/balancer/roundrobin" // To register roundrobin.
_ "google.golang.org/grpc/internal/resolver/dns" // To register dns resolver.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YoyinZyc similar to my above comment - while looking at the couple of issues #11532 and #11529
, I think that these issues are might be because of https://github.com/etcd-io/etcd/tree/master/vendor/google.golang.org/grpc/internal doesn't have the referenced internal/resolver package. The https://github.com/grpc/grpc-go/tree/master/internal has it there. I haven't worked on updating etcd vendor files before but I believe having vendor dir updated with these packages should fix it. Please let me know what you think? Thanks!

gdbelvin pushed a commit to gdbelvin/etcd that referenced this pull request May 11, 2020
@gdbelvin gdbelvin mentioned this pull request May 11, 2020
xiang90 pushed a commit that referenced this pull request May 13, 2020
* clientv3: fix grpc-go(v1.27.0) incompatible changes to balancer/resolver.

* vendor: upgrade gRPC Go to v1.24.0

Picking up some performance improvements and bug fixes.

https://github.com/grpc/grpc-go/releases/tag/v1.24.0

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>

* vendor: update gRPC Go to v1.26.0 (#11522)

* GO111MODULE=on go mod vendor

* GO111MODULE=on go mod vendor go 1.14

Bump travis 2

Co-authored-by: EDDYCJY <313687982@qq.com>
Co-authored-by: Gyuho Lee <leegyuho@amazon.com>
Co-authored-by: Yuchen Zhou <yczhou@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants