Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify grpc dialer usage in clientv3 #11519

Closed
jpbetz opened this issue Jan 14, 2020 · 2 comments · Fixed by #11574
Closed

Simplify grpc dialer usage in clientv3 #11519

jpbetz opened this issue Jan 14, 2020 · 2 comments · Fixed by #11574
Labels
area/clientv3
Milestone
etcd-v3.5

Comments

@jpbetz
Copy link
Contributor

jpbetz commented Jan 14, 2020

With grpc/grpc-go#3073 released via https://github.com/grpc/grpc-go/releases/tag/v1.25.0 we can now adopt it in etcd and remove the workaround introduced in #11184.

@jingyih @YoyinZyc Would one of you be willing to take this one?
@jpbetz jpbetz added this to the etcd-v3.5 milestone Jan 14, 2020
@YoyinZyc
Copy link
Contributor

I will have a look.

@jpbetz
Copy link
Contributor Author

jpbetz commented Jan 14, 2020

Thanks @YoyinZyc. Let's bump grpc to 1.26.0 in go.mod since that's the grpc version kubernetes is upgrading to, and there's no reason not to pick up the latest.

cc @dims @liggitt

@YoyinZyc YoyinZyc mentioned this issue Jan 15, 2020
Merged
@YoyinZyc YoyinZyc mentioned this issue Jan 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/clientv3
Milestone
etcd-v3.5
Development

Successfully merging a pull request may close this issue.

clientv3: simplify grpc dialer usage. YoyinZyc/etcd
2 participants
@jpbetz @YoyinZyc