Gestion erreur timeout pour validateur GTFS #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoineAugusti
commented
May 10, 2022
| @@ -74,6 +75,10 @@ defmodule Shared.Validation.GtfsValidator do | |||
| {:error, "Error while requesting GTFS validator"} | |||
| end | |||
|
|
|||
| defp handle_validation_response({:error, _}) do | |||
There was a problem hiding this comment.
La clause précédente faisait comme s'il y avait toujours un body, ce qui n'arrive pas en cas de timeout à la connexion ou à la réception.
thbar
approved these changes
May 10, 2022
thbar
added a commit
that referenced
this pull request
Oct 31, 2022
I have Postgres 14 locally, maybe this explains this failure.
thbar
added a commit
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lié à #2376
En regardant les erreurs de la validation/validation à la demande, je tombe sur un cas qui ne semble pas être traité par le code existant, le cas de timeout lors de l'appel HTTP au validateur GTFS.
La stacktrace enregistrée est
ce qui est assez cryptique. J'ai déjà vu ça dans le backoffice aussi.
La façon de gérer les timeouts avec HTTPoison est assez bancale edgurgel/httpoison#215 mais ma compréhension est que ça devrait être
%HTTPoison.Error{reason: :timeout}.