Replacing Redis.current (deprecated) #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Samuelfaure
force-pushed
the
clean/redis
branch
from
57486b5
to
a3bb3fc
Compare
|
A la lumière de ce thread redis/redis-rb#1064 j'instancierai une connexion locale juste dans le status page. |
|
@skelz0r Le dernier commit est-il bien ce que tu proposes? |
skelz0r
reviewed
Feb 14, 2022
skelz0r
reviewed
Feb 14, 2022
oui |
skelz0r
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis.current est deprecated et sera supprimé bientôt (et les messages d'alerte sont relous)
A la place je propose une global var dans les initializers (on fait déjà ça pour ElasticSearch). C'est pas le plus propre mais AFAIK ça devrait rien changer de l'actuel.
Attention j'ai zéro experience avec Redis donc reviewez prudemment...