Export getPath #126
Open
Export getPath #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a useful utility function outside the library, and folks who are doing selectors (like me) will often want to do something like this without having to build up a whole selector. I think it's useful enough and simple enough to make part of the public API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a useful utility function outside the library, and folks who are doing selectors (like me) will often want to do something like this without having to build up a whole selector. I think it's useful, in keeping with the goal of the library, and simple enough to make part of the public API.
I'm using esquery for the first time today and it's very useful! I just went to try to use
getPathwhich I'd been looking for a simple implementation of anyway, and found it wasn't exported, so figured I'd give it a shot after not seeing similar requests in the issue history.