- Linting: Temporarily disable most linting, with a few fixes

estools · May 6, 2020 · ad28bf2 · ad28bf2
1 parent 93c1587
commit ad28bf2
Show file tree

Hide file tree

Showing 12 changed files with 23 additions and 20 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -33,29 +33,33 @@ module.exports = {
     }],
     rules: {
         // 'push-with-multiple-arguments': 2,
+        /*
         'no-unused-vars': [
             2,
             {
                 vars: 'all',
                 args: 'none'
             }
         ],
+        */
+        'no-unused-vars': 0,
+        'no-prototype-builtins': 0,
         'new-cap': [
             2,
             {
                 capIsNew: false
             }
         ],
         semi: ['error'],
-        indent: ['error', 4, { SwitchCase: 1 }],
+        // indent: ['error', 4, { SwitchCase: 1 }],
         'prefer-const': ['error'],
-        'no-var': ['error'],
-        'prefer-destructuring': ['error'],
-        'object-shorthand': ['error'],
-        'object-curly-spacing': ['error', 'always'],
-        quotes: ['error', 'single'],
-        'quote-props': ['error', 'as-needed'],
-        'brace-style': ['error', '1tbs', { allowSingleLine: true }],
-        'prefer-template': ['error']
+        // 'no-var': ['error'],
+        // 'prefer-destructuring': ['error'],
+        // 'object-shorthand': ['error'],
+        // 'object-curly-spacing': ['error', 'always'],
+        // quotes: ['error', 'single'],
+        // 'quote-props': ['error', 'as-needed'],
+        'brace-style': ['error', '1tbs', { allowSingleLine: true }]
+        // 'prefer-template': ['error']
     }
 };
diff --git a/benchmark/index.js b/benchmark/index.js
@@ -24,7 +24,7 @@ new Benchmark.Suite()
     })
 
     .on('start', function () {
-        console.log('Benchmarking...')
+        console.log('Benchmarking...');
     })
 
     .on('cycle', function (event) {

diff --git a/benchmark/old.js b/benchmark/old.js
@@ -31,7 +31,6 @@
   THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-/*global exports:true, require:true, global:true*/
 (function () {
     'use strict';
 

diff --git a/bin/esgenerate.js b/bin/esgenerate.js
@@ -51,7 +51,7 @@ if (files.length === 0) {
 
 if (args.config) {
     try {
-        options = JSON.parse(fs.readFileSync(args.config, 'utf-8'))
+        options = JSON.parse(fs.readFileSync(args.config, 'utf-8'));
     } catch (err) {
         console.error('Error parsing config: ', err);
     }

diff --git a/escodegen.js b/escodegen.js
@@ -33,7 +33,6 @@
   THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-/*global exports:true, require:true, global:true*/
 (function () {
     'use strict';
 

diff --git a/escodegen.js.map b/escodegen.js.map
diff --git a/test/ast.js b/test/ast.js
@@ -60,7 +60,7 @@ data = {
                 type: 'ExpressionStatement',
                 expression: {
                     type: 'Literal',
-                    value: new RegExp('\n', 'i')
+                    value: /\n/i
                 },
             }],
             expected: '/\\n/i;'
@@ -71,7 +71,7 @@ data = {
                 type: 'ExpressionStatement',
                 expression: {
                     type: 'Literal',
-                    value: new RegExp('\r', 'i')
+                    value: /\r/i
                 },
             }],
             expected: '/\\r/i;'

diff --git a/test/loader.js b/test/loader.js
@@ -37,7 +37,7 @@ function freezing(escodegen) {
         return original.apply(this, arguments);
     };
     return escodegen;
-};
+}
 
 module.exports = freezing(escodegen);
 

diff --git a/test/source-map.js b/test/source-map.js
@@ -470,7 +470,7 @@ describe('source map test', function () {
     });
 
     it('sourceContent support', async function() {
-        var source = "(+ a b)"
+        var source = "(+ a b)";
         var ast = {
             "type": "ExpressionStatement",
             "expression": {"type": "BinaryExpression",

diff --git a/test/test.js b/test/test.js
@@ -13603,7 +13603,7 @@ data = {
                             expression: {
                                 type: 'Literal',
                                 value: 'use strict',
-                                raw: '\"use strict\"',
+                                raw: '"use strict"',
                                 range: [37, 49],
                                 loc: {
                                     start: { line: 1, column: 37 },

diff --git a/tools/entry-point.js b/tools/entry-point.js
@@ -25,5 +25,5 @@
 (function () {
     'use strict';
     global.escodegen = require('../escodegen');
-    escodegen.browser = true;
+    global.escodegen.browser = true;
 }());
diff --git a/tools/rules/push-with-multiple-arguments.js b/tools/rules/push-with-multiple-arguments.js
@@ -22,7 +22,7 @@
   THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */
 
-'use strict'
+'use strict';
 
 module.exports = function (context) {
     var MESSAGE = '"push" with multiple arguments hurts performance since optimizing compiler would not support it';