feat: Allow cert-manager certs to be issued by a cluster issuer #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@estahn I rebased this to get rid of the conflicts |
|
@estahn When you get a chance will you take a look at this? |
|
@estahn this is a pretty small PR, do you think you can take a look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Cert-manager allows both namespaced issuers and cluster level issuers. Currently the certificate doesn't specify a kind and therefore only uses the default which is a namespaced issuer. For those that use cluster issuers it would be good to let them specify that.
Changes
This change allows the user to choose between having an Issuer and a ClusterIssuer for the certificate. It will still default to Issuer if the user doesn't set the value.
Code Author Checklist
Chart.yaml->version)values.schema.json)README.mdvia helm-docs (ormake prep)pre-commit run --all-filesvia pre-commit (ormake prep)Chart.yaml->artifacthub.io/changes,artifacthub.io/images)