Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extraEnv for httpbingo chart #143

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

plumdog
Copy link

@plumdog plumdog commented Sep 5, 2023

Purpose

#142

Changes

Testing

$ helm template . --set extraEnv.FOO=bar | yq '. | select(.kind == "Deployment") | .spec.template.spec.containers[0].env'
- name: FOO
  value: "bar"

Code Author Checklist

  • Bump the chart version (Chart.yaml -> version)
  • JSON Schema updated (values.schema.json) - ❗ n/a, no such file for this chart
  • Update README.md via helm-docs (or make prep)
    • no, I get an error: make: helm-docs: No such file or directory
  • Run pre-commit run --all-files via pre-commit (or make prep)
  • Update Artifacthub annotation (Chart.yaml -> artifacthub.io/changes, artifacthub.io/images)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant