-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Urdu Shrutilipi dataset #5775
base: master
Are you sure you want to change the base?
Urdu Shrutilipi dataset #5775
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! May I ask if all the configs are necessary? In the usualy cases, it would be great to be simple for the first PR of the recipe.
@@ -0,0 +1,17 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please follow the existing recipe data.sh for checking db.sh for where to save data?
@VanyaBK, can you fix the issues pointed out by the above reviews? |
exit 1 | ||
fi | ||
|
||
python3 data_prep.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be recommended to input URDU_SHRUTILIPI for the script especially consider users may change to other directories
@@ -0,0 +1 @@ | |||
tuning/train_asr_e_branchformer_size256_mlp1024_linear1024_e12_mactrue_edrop0.0_ddrop0.0.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary configs are missing now
--ngpu 1 \ | ||
--nj 16 \ | ||
--gpu_inference true \ | ||
--inference_nj 2 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--ngpu 1 \ | |
--nj 16 \ | |
--gpu_inference true \ | |
--inference_nj 2 \ |
We can keep it default here
What?
Added the Urdu Shrutilipi recipe
Why?
Initial commit
See also
Need access to huggingface, to upload the model