Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LVGL implementation for ESPHome #6363

Open
wants to merge 134 commits into
base: dev
Choose a base branch
from
Open

Conversation

clydebarrow
Copy link
Contributor

@clydebarrow clydebarrow commented Mar 12, 2024

What does this implement/fix?

Implements LVGL in ESPHome in a native way - configured with YAML.

To use this PR prior to being merged, add this to your yaml:

external_components:
  - source: github://pr#6363
    refresh: 10min
    components: [lvgl]

And read the docs as below:

Doc preview is here: https://deploy-preview-3678--esphome.netlify.app/components/lvgl.html

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other

Related issue or feature (if applicable): fixes

Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#3678

Test Environment

  • ESP32
  • ESP32 IDF
  • ESP8266
  • RP2040
  • BK72xx
  • RTL87xx

Example entry for config.yaml:

# Example config.yaml

Checklist:

  • The code change is tested and works locally.
  • Tests have been added to verify that the new code works (under tests/ folder).

If user exposed functionality or configuration variables are added/changed:

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.13%. Comparing base (4d8b5ed) to head (7aba6f5).
Report is 626 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #6363      +/-   ##
==========================================
+ Coverage   53.70%   54.13%   +0.42%     
==========================================
  Files          50       50              
  Lines        9408     9619     +211     
  Branches     1654     1698      +44     
==========================================
+ Hits         5053     5207     +154     
- Misses       4056     4086      +30     
- Partials      299      326      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nielsnl68
Copy link
Contributor

🥰

@SeByDocKy
Copy link
Contributor

Whaooohhhh massive addition .... Congrats!!!

@HenryLoenwind
Copy link

I just read through the documentation and noticed that this seems to only support touchscreens and rotary encoders. It would be nice if support for what LVGL calls keypad input was added. While adding support for all ways buttons can be connected (direct pin, digital matrix, analogue matrix, ...) would be a bit daunting, offering an action to send button presses to LVGL should be viable.

I can see myself slapping a graphic display onto my ESP32 and adding two buttons (LV_KEY_RIGHT and LV_KEY_ENTER)---checking what cheap display I could use brought me here after all---but I wouldn't go for a touchscreen or rotary. Also, I think for using the onscreen keyboard you'd want a touchscreen or some 5-button input, not a rotary.

@nagyrobi
Copy link
Member

nagyrobi commented May 18, 2024

Hah like in the good ole days we used to control the Nokia GSM phones, just 3 buttons for the entire screen menu, where the middle one was always "OK" and the two side ones were context-sensitive "Soft" buttons... The numeric keypad was fixed...

@clydebarrow
Copy link
Contributor Author

It would be nice if support for what LVGL calls keypad input was added

That will come, but is not on the list for the first release - have to draw line somewhere or it will never be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet