A helper class that could resolve from "hosts", mDNS and finally DNS #5648
+385
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-esphome
bot
added
core
integration: mdns
integration: network
integration: wifi
labels
HeMan
force-pushed
the
resolver
branch
6 times, most recently
from
d083b66
to
739e866
Compare
jesserockz
reviewed
Nov 8, 2023
HeMan
force-pushed
the
resolver
branch
3 times, most recently
from
7f1cd4e
to
f1b5f50
Compare
HeMan
force-pushed
the
resolver
branch
5 times, most recently
from
756d15f
to
4ddfe98
Compare
bdraco
reviewed
Dec 17, 2023
bdraco
reviewed
Dec 17, 2023
bdraco
reviewed
Dec 19, 2023
bdraco
reviewed
Dec 19, 2023
| std::vector<network::IPAddress> resolved; | ||
| mdns_result_t *results = nullptr; | ||
| mdns_ip_addr_t *a = nullptr; | ||
| esp_err_t err = mdns_query_ptr(("_" + servicename).c_str(), "_tcp", 3000, 20, &results); |
There was a problem hiding this comment.
I think the goal here is to look for a A/AAAA record?
Maybe
mdns_query(servicename, NULL, NULL, MDNS_TYPE_ANY, 20, &results);
or maybe MDNS_TYPE_A, MDNS_TYPE_AAAA?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #5648 +/- ##
==========================================
+ Coverage 53.70% 53.91% +0.20%
==========================================
Files 50 50
Lines 9408 9625 +217
Branches 1654 1698 +44
==========================================
+ Hits 5053 5189 +136
- Misses 4056 4112 +56
- Partials 299 324 +25 ☔ View full report in Codecov by Sentry. |
Co-authored-by: J. Nick Koston <nick@koston.org>
HeMan
force-pushed
the
resolver
branch
2 times, most recently
from
7a81bc9
to
f438012
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
There are currently no way to have anything similar to an /etc/hosts-file. This adds that (would solve esphome/feature-requests#2008), but also a common way to resolve names by mDNS and regular DNS. The mDNS support is intentional simplified to search for a service with the "hostname" asked for.
Could be breaking for external components
Todo:
/etc/hosts-like filesTypes of changes
Related issue or feature (if applicable): fixes
Pull request in esphome-docs with documentation (if applicable): esphome/esphome-docs#
Test Environment
Example entry for
config.yaml:# Example config.yamlChecklist:
tests/folder).If user exposed functionality or configuration variables are added/changed: