Write the image to the correct target app partition #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simpkins
force-pushed
the
target-app-partition
branch
from
cb9779e
to
a7f5a93
Compare
simpkins
force-pushed
the
target-app-partition
branch
from
a7f5a93
to
5bed5a1
Compare
This updates the code to honor the --target-app-partition flag, and write the application image to the specified partition. Previously the code always wrote the image to the "factory" app partition if one was present, regardless of the partition specified with the `--target-app-partition` flag. (It seems like this behavior was likely broken in d886d33, which updated the code to always write to the factory partition again.) I confirmed that using `espflash flash --target-app-partition ota_0` now causes espflash to write the image to the `ota_0` partition. Note that this leaves the `factory` partition and any `ota_data` partition unchanged, so the bootloader will still boot from the factory partition by default, but this makes it possible to write new app images to the OTA partitions for testing purposes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps I am misunderstanding what the --target-app-partition flag is supposed to do, but the code previously always wrote the image to the "factory" app partition if one was present, regardless of the partition specified with the
--target-app-partitionflag.This change updates the code to write the image to the partition specified with the
--target-app-partitionflag.I confirmed that using
espflash flash --target-app-partition ota_0now causes espflash to write the image to theota_0partition. Note that this leaves thefactorypartition and anyota_datapartition unchanged, so the bootloader will still boot from the factory partition by default, but this makes it possible to write new app images to the OTA partitions for testing purposes.