Skip to content

Commit

Permalink
Fix CI
Browse files Browse the repository at this point in the history
  • Loading branch information
@ivmarkov
ivmarkov committed May 6, 2024
1 parent 4be9db5 commit 8d0c991
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/lib.rs
View file
Expand Up @@ -10,6 +10,9 @@
all(not(feature = "std"), feature = "alloc_handler"),
feature(alloc_error_handler)
)]
#![allow(unknown_lints)]
#![allow(renamed_and_removed_lints)]
#![allow(unexpected_cfgs)]

pub use bindings::*;
pub use error::*;
Expand Down

2 comments on commit 8d0c991

@Urgau
Copy link

@Urgau Urgau commented on 8d0c991 May 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heads up, @ivmarkov, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19). Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Footnotes

  1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below ↩

@Vollbrecht
Copy link
Collaborator

@Vollbrecht Vollbrecht commented on 8d0c991 May 24, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Urgau Thanks for the information! The above was more or less a stopgap solution till we find the time to fix it in our build-scripts. Since our target is nightly only we always living on the etch, and sometimes this massive lints can throw a wrench into the daily work with not to much benefit. Technically its a nice lint, though most our configs come from outside of rust and are not existing for every compilation run upstream, have to come back later how it pens out directly.

Please sign in to comment.