feat: sync v8.31.0 #94
Conversation
✅ Deploy Preview for zh-hans-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
These changes look good.
Two questions:
- Should we also include the fix in
formatters/index.md? (eslint/eslint@d9a39c7) - Since we're copying all files, the left sidebar menu now has duplicate items (e.g., there is [用户指南] and Use ESLint in your project). Is that okay for now?
I will update it.
Structural changes are included in v8.32.0. I will finish it sync as soon as possible. I think this PR should be merged together at the same time as the upcoming sync PR for v8.32.0 is approved. Before that this PR should be blocked. |
|
This would be great to install because the chinese documentation has two versions of the links on the documentation site. |
I originally thought that the current site did not deploy commits with structural changes, so needed to merge both v8.31.0 and v8.32.0 to avoid duplicate content. But it turns out that I was wrong, and the current site has already deployed the commits that have changed structure, so in normal order, v8.31.0 is merged first and then v8.32.0 is merged. But we should also merge v8.32.0 as soon as possible, because it's too bad that the menu bar has duplicate content. I also plan to take steps to have the version of content automatically pulled match the translated version, rather than always pulling the latest docs. |
|
Makes sense! |
|
Note that the HTML formatter page that should appear in an iframe is missing, but that doesn't seem to be caused by this particular change.
|
Makes sense, I'll let you merge this when and how you think it would be best. |
Co-authored-by: Strek <ssharishkumar@gmail.com>
|
Sorry it took so long to process, but my computer recently broke down and just got fixed. |
* docs: User Guide Getting Started expansion * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: adjust some words * docs: Add function call example for no-undefined eslint/eslint#16712 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * update formatters * Apply suggestions from code review Co-authored-by: Strek <ssharishkumar@gmail.com> --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
* docs: User Guide Getting Started expansion * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: adjust some words * docs: Add function call example for no-undefined eslint/eslint#16712 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * update formatters * Apply suggestions from code review Co-authored-by: Strek <ssharishkumar@gmail.com> --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
* docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * docs: use inline code for rule options name eslint/eslint#16768 * docs: ignore directives for no-fallthrough eslint/eslint#16757 * docs: IA Update page URL move eslint/eslint#16665 * update * feat: sync v8.31.0 (#94) * docs: User Guide Getting Started expansion * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: adjust some words * docs: Add function call example for no-undefined eslint/eslint#16712 * docs: check assignment patterns in no-underscore-dangle eslint/eslint#16693 * update formatters * Apply suggestions from code review Co-authored-by: Strek <ssharishkumar@gmail.com> --------- Co-authored-by: Strek <ssharishkumar@gmail.com> * docs: add options to check destructuring in no-underscore-dangle eslint/eslint#16006 * docs: IA Update page URL move eslint/eslint#16665 --------- Co-authored-by: Strek <ssharishkumar@gmail.com>
Prerequisites checklist
What is the purpose of this pull request?
sync v8.31.0 from eslint repo
What changes did you make? (Give an overview)
Related Issues
Is there anything you'd like reviewers to focus on?