This repository has been archived by the owner on Jan 19, 2019. It is now read-only.
Upgrade: eslint-release@1.0.0 #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(refs eslint/eslint#10631) This updates `eslint-release` to allow the package to still be published from the Jenkins server now that we have 2FA enabled on the bot account. Some changes are also needed on the Jenkins server -- I plan to make those changes after this is merged.
platinumazure
approved these changes
Oct 17, 2018
|
Thanks @not-an-aardvark I'll ping you on gitter |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(refs eslint/eslint#10631)
This updates
eslint-releaseto allow the package to still be published from the Jenkins server now that we have 2FA enabled on the bot account.Some changes are also needed on the Jenkins server -- I plan to make those changes after this is merged.
@JamesHenry We've enabled 2FA for the bot npm account on the Jenkins server, so from now on you'll need to be able to generate 2FA codes in order to publish with the ESLint Jenkins server. Do you have a Keybase account or PGP key that I can use to encrypt the QR code and send it to you? I'm also happy to answer any questions here/on Gitter/somewhere else.