Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add 2023-03-23 meeting notes #419

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Conversation

sam3k
Copy link
Contributor

@sam3k sam3k commented Mar 25, 2023

Closes: #417

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just left one suggestion.

notes/2023/2023-03-23.md Outdated Show resolved Hide resolved
**Do we want to keep reporting on IIFEs inside of async and generator functions?**
Yes, we should keep reporting on that, as it's a code that isn't immediately executed

**Resolution:** we have agreed to:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
@sam3k
Copy link
Contributor Author

sam3k commented Mar 29, 2023

@nzakas I've accepted the change. Thank you. It's ready for you.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @mdjermanovic can you approve?

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mdjermanovic mdjermanovic merged commit 549817e into eslint:main Mar 30, 2023
@nzakas
Copy link
Member

nzakas commented Mar 31, 2023

@sam3k it looks like this issue hasn't yet been updated: eslint/eslint#16954

Thanks so much for your help with the meeting notes. It is very much appreciated. 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSC meeting 23-March-2023
3 participants