-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add 2023-03-23 meeting notes #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just left one suggestion.
**Do we want to keep reporting on IIFEs inside of async and generator functions?** | ||
Yes, we should keep reporting on that, as it's a code that isn't immediately executed | ||
|
||
**Resolution:** we have agreed to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. 👍
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
@nzakas I've accepted the change. Thank you. It's ready for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @mdjermanovic can you approve?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@sam3k it looks like this issue hasn't yet been updated: eslint/eslint#16954 Thanks so much for your help with the meeting notes. It is very much appreciated. 🙏 |
Closes: #417