Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: eslint-release@1.0.0 #66

Merged
merged 1 commit into from Oct 27, 2018
Merged

Conversation

not-an-aardvark
Copy link
Member

(refs eslint/eslint#10631)

This updates eslint-release to allow the package to still be published from the Jenkins server now that we have 2FA enabled on the bot account.

Some changes are also needed on the Jenkins server -- I plan to make those changes after this is merged.

(refs eslint/eslint#10631)

This updates `eslint-release` to allow the package to still be published from the Jenkins server now that we have 2FA enabled on the bot account.

Some changes are also needed on the Jenkins server -- I plan to make those changes after this is merged.
@not-an-aardvark
Copy link
Member Author

It seems like the tests are failing on Node versions less than 6, apparently due to a breaking change in some dependency which is using default parameters.

@platinumazure
Copy link
Member

I figured it would be something like that. I think it's about time to modernize this repo and do a breaking change. Can I work with you @not-an-aardvark to do that release later? (Not sure if I'll need help and/or a non-2FA release.)

@not-an-aardvark
Copy link
Member Author

Sure, happy to help. Since 2FA has the granularity of a single account, the only way to do a non-2FA release of this package would be to disable 2FA for the entire eslint account, which doesn't seem ideal (e.g. we would need to change the shared 2FA key).

I think the simplest way for us to go about things would be:

  • We merge this PR so that it's possible to do 2FA releases of this package. From looking briefly at the test failures, it doesn't seem like they're related to this PR. (The tests are still passing on recent versions of Node, so the failing tests hopefully wouldn't interfere with a release.)
  • I'll update the generator-eslint Jenkins build to support getting 2FA input.
  • If you follow the instructions in Docs: add instructions for npm 2FA (refs #10631) eslint#10992 to get the 2FA key, then you should be able to do releases with 2FA on Jenkins, including releases of this package.

@not-an-aardvark
Copy link
Member Author

(Or alternatively, we could wait to merge this PR until after we do a breaking change and the tests pass -- the only requirement would be that we need to merge something like this PR before we can do a release.)

@not-an-aardvark
Copy link
Member Author

@platinumazure What would be your thoughts on merging this before fixing the other test failures? I think this is the last remaining task before we can close eslint/eslint#10631. It would be nice if we could complete that project soon even if upgrading the other parts of this repo aren't a high priority.

@platinumazure
Copy link
Member

@not-an-aardvark Agreed. I've approved. Can't merge on the mobile site due to the failing status check, can you merge please? Thanks!

@not-an-aardvark not-an-aardvark merged commit 51d9529 into master Oct 27, 2018
@not-an-aardvark not-an-aardvark deleted the upgrade-eslint-release branch October 27, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants