chore: standardize npm script names #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snitin315
commented
Jul 29, 2023
Comment on lines
-44
to
-45
| - name: Build commonjs | ||
| run: npm run build |
There was a problem hiding this comment.
build happens via the pretest script.
There was a problem hiding this comment.
Can you also update README (npm test will no longer include linting):
Line 186 in 086555e
nzakas
requested changes
Aug 1, 2023
mdjermanovic
reviewed
Aug 2, 2023
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
mdjermanovic
approved these changes
Aug 6, 2023
Merged
Updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request?
Refers eslint/eslint#14827
What changes did you make? (Give an overview)
This updates the names of the scripts in package.json to be consistent with the new standard.
Is there anything you'd like reviewers to focus on?
We may need to update the
releaserelated scripts on Jenkins before merging this PR.