Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ES2024 and regexp v flag #575

Merged
merged 2 commits into from Jun 19, 2023
Merged

feat: Support ES2024 and regexp v flag #575

merged 2 commits into from Jun 19, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 24, 2023 •
edited

This PR enables ES2024 and changes ES2024 to the latest supported version.
It also adds support for the regexp v flag.

Acorn has been merged with changes that add support for the regexp v flag. (But not yet released.)
acornjs/acorn#1219 (comment)
acornjs/acorn@1f8c7f1
acornjs/acorn@fb4c582

See also:
https://github.com/tc39/proposal-regexp-v-flag
tc39/ecma262#2418

@sosukesuzuki sosukesuzuki mentioned this pull request May 25, 2023
Closed
19 tasks
@ota-meshi ota-meshi marked this pull request as ready for review June 18, 2023 02:46
nzakas
nzakas approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Would like @mdjermanovic to approve before merging.

mdjermanovic
mdjermanovic approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open in case anyone else wants to review it before merging.

tests/fixtures/ecma-version/15/regexp-v-flag/invalid-regexp-v-flag.result.js
"index": 13,
"lineNumber": 1,
"column": 14,
"message": "Invalid regular expression flag"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message is kind of misleading as all the flags are valid regex flags but the combination (uv) is invalid. Nothing we can do about it in espree, though.

@mdjermanovic
Copy link
Member

LGTM, thanks! Leaving open in case anyone else wants to review it before merging.

Didn't see the other approval. Merging now

@mdjermanovic mdjermanovic merged commit 4cfc062 into eslint:main Jun 19, 2023
14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 19, 2023
Merged
@matz3
Copy link
Contributor

matz3 commented Jun 19, 2023

So this means ES2023 is final, right?

@mdjermanovic
Copy link
Member

So this means ES2023 is final, right?

Yes, here's the specification: https://tc39.es/ecma262/2023/

Hashbang Grammar was the only syntax addition in ES2023 (to check, see https://github.com/tc39/proposals/blob/main/finished-proposals.md, last column is the spec year) and espree supports it.

@ota-meshi ota-meshi deleted the es2024 branch June 19, 2023 21:27
@mdjermanovic mdjermanovic mentioned this pull request Jun 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nzakas nzakas nzakas approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted contributor pool feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ota-meshi @mdjermanovic @matz3 @nzakas