Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking: Disallow reserved words in ES3 #513

Merged
merged 2 commits into from Sep 10, 2021
Merged

Breaking: Disallow reserved words in ES3 #513

merged 2 commits into from Sep 10, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Sep 7, 2021

Disallows reserved words in ES3 mode.

Refs eslint/eslint#15017

@nzakas nzakas mentioned this pull request Sep 7, 2021
Closed
mdjermanovic
mdjermanovic reviewed Sep 8, 2021
View reviewed changes
lib/options.js Outdated Show resolved Hide resolved
@mdjermanovic
Copy link
Member

#514 fixes errors in CI.

@mdjermanovic mdjermanovic mentioned this pull request Sep 8, 2021
Merged
@nzakas
Copy link
Member Author

nzakas commented Sep 9, 2021

Updated and rebased so tests will pass.

mdjermanovic
mdjermanovic approved these changes Sep 9, 2021
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 7952c6f into main Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aladdin-add aladdin-add aladdin-add approved these changes

@mdjermanovic mdjermanovic mdjermanovic approved these changes

Assignees
No one assigned
Labels
accepted breaking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nzakas @mdjermanovic @aladdin-add