Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: reset default ecmaVersion to 5 #506

Merged
merged 2 commits into from Jun 23, 2021
Merged

Update: reset default ecmaVersion to 5 #506

merged 2 commits into from Jun 23, 2021

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 17, 2021

Per the 2021-06-17 TSC meeting, reverting so ecmaVersion is set to 5 if not present.

@aladdin-add
Copy link
Member

I've resubmitted a PR in eslint repo: eslint/eslint#14720, which set the default ecmaVersion to 5.

/ cc @mdjermanovic

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one suggestion about the tests, otherwise LGTM!

tests/lib/parse.js Outdated Show resolved Hide resolved
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
@nzakas nzakas merged commit 9eff2c7 into main Jun 23, 2021
@nzakas nzakas deleted the default-ecmaversion branch June 23, 2021 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants