Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: acorn 5.4.0 #367

Merged
merged 1 commit into from Feb 3, 2018
Merged

Upgrade: acorn 5.4.0 #367

merged 1 commit into from Feb 3, 2018

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Jan 25, 2018

Refs eslint/eslint#9885 and eslint/eslint#9891.

This is WIP. Done!

This PR upgrades acorn and add tests for Async Iteration and Rest/Spread Properties.

  1. This updates acorn.
  2. This adds some tests to check the new syntax.
  3. This adds a test to check the combination of ecmaVersion:2018 and ecmaFeatures.experimentalObjectRestSpread:true.

@marijnh
Copy link

marijnh commented Jan 26, 2018

We've merged #658, which does the same thing I believe

@mysticatea mysticatea changed the title [WIP] Upgrade: update acorn to support rest/spread properties [WIP] Upgrade: update acorn to support async iterations and rest/spread properties Jan 26, 2018
@mysticatea mysticatea changed the title [WIP] Upgrade: update acorn to support async iterations and rest/spread properties Upgrade: acorn 5.4.0 Feb 1, 2018
@mysticatea
Copy link
Member Author

Ready to review!

@not-an-aardvark not-an-aardvark merged commit 70f9859 into master Feb 3, 2018
@not-an-aardvark not-an-aardvark deleted the rest-spread-properties branch February 3, 2018 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants