chore: upgrade ignore to v5.2.0

[snitin315]

Fix eslint/eslint#15642

Upgrade ignore to v5.2.0. Use { allowRelativePaths: true } to get the v4 behavior.

[mdjermanovic]

Can you add some tests that would confirm that this fixes eslint/eslint#15642?

[mdjermanovic]

My main concern with this is - is the behavior we were expecting from ignore 4.0.6 well tested. In other words, will our tests catch if this upgrade changes ESLint's behavior other than fixing the bug.

I made mdjermanovic#1 to check if eslint/eslintrc tests will fail without { allowRelativePaths: true } which enables backward compatibility. In this repo, only one test fails (this one). The test has some windows paths and fails only on posix, so it doesn't seem representative. That's bad.

On the other hand, 40 tests are failing in eslint/eslint repo without { allowRelativePaths: true } (mdjermanovic/eslint#1), while everything works well with { allowRelativePaths: true } (mdjermanovic/eslint#2), i.e. with this branch. That looks good enough.

[nzakas]

On the other hand, 40 tests are failing in eslint/eslint repo without { allowRelativePaths: true } (mdjermanovic/eslint#1), while everything works well with { allowRelativePaths: true } (mdjermanovic/eslint#2), i.e. with this branch. That looks good enough.

I'm guessing one of these should be allowRelativePaths: false?

[mdjermanovic]

On the other hand, 40 tests are failing in eslint/eslint repo without { allowRelativePaths: true } (mdjermanovic/eslint#1), while everything works well with { allowRelativePaths: true } (mdjermanovic/eslint#2), i.e. with this branch. That looks good enough.

I'm guessing one of these should be allowRelativePaths: false?

Hm, no. Tests are failing without { allowRelativePaths: true } (i.e. with the default { allowRelativePaths: false }), and passing with { allowRelativePaths: true }.

[snitin315]

Can you add some tests that would confirm that this fixes eslint/eslint#15642?

Looks like you opened eslint/eslint#15666 for the same.

I'm guessing one of these should be allowRelativePaths: false?

No, because we were already using allowRelativePaths: true by default in ignore@v4. They changed the default to false in v5. So, now we need to explicitly mention it as true to get the old behavior.

[mdjermanovic]

LGTM, thanks!

[nzakas]

Okay, I realize I missed “with” vs “without”. My apologies for the confusion.

[nzakas]

Let’s make sure the main repo is also upgraded.