Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update globals to version 13.6 #32

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

realityking
Copy link
Contributor

@realityking realityking commented Apr 9, 2021

This matches the version required by eslint and allows for deduplication

The upgrade commit for eslint is 5ad91aa7df3d6bc185786e6eccd9e055fd951055

Deduplication will help with eslint/eslint#14098

@eslint-github-bot
Copy link

Hi @realityking!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @realityking!, thanks for the Pull Request

The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag must be one of the following:

    The Tag is one of the following:

    • Fix - for a bug fix.
    • Update - either for a backwards-compatible enhancement or for a rule change that adds reported problems.
    • New - implements a new feature.
    • Breaking - for a backwards-incompatible enhancement or feature.
    • Docs - changes to documentation only.
    • Build - changes to build process only.
    • Upgrade - for a dependency upgrade.
    • Chore - for anything that isn't user-facing (for example, refactoring, adding tests, etc.).

    You can use the labels of the issue you are working on to determine the best tag.

  • There should be a space following the initial tag and colon, for example 'New: Message'.

  • The first letter of the tag should be in uppercase

Read more about contributing to ESLint here

This matches the version required by eslint and allows for deduplication
@realityking realityking changed the title chore: update globals to version 13.6 Chore: update globals to version 13.6 Apr 9, 2021
package.json Outdated
@@ -50,7 +50,7 @@
"ajv": "^6.12.4",
"debug": "^4.1.1",
"espree": "^7.3.0",
"globals": "^12.1.0",
"globals": "^13.6.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

globals is up to 13.9 now, which is still compatible with the version defined in eslint

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

package.json Outdated Show resolved Hide resolved
@aladdin-add aladdin-add merged commit cc79a4d into eslint:main Jun 3, 2021
@edg2s
Copy link

edg2s commented Jun 3, 2021

Could this be made available with a minor or patch release?

@mdjermanovic
Copy link
Member

Could this be made available with a minor or patch release?

Yes, this will be released tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants