Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add "resolveSharedConfigsRelativeTo" config option #159

Closed

Conversation

onlywei
Copy link

@onlywei onlywei commented May 9, 2024

I need this option because of: eslint/eslint#18414

I also cannot upgrade to ESLint v9.x yet because both @typescript-eslint/parser and nx do not support v9.x yet.

Copy link

linux-foundation-easycla bot commented May 9, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

@eslint-github-bot
Copy link

Hi @onlywei!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@onlywei onlywei force-pushed the resolve-shared-configs-relative-to branch from d65883d to e51d0eb Compare May 9, 2024 21:17
@eslint-github-bot
Copy link

Hi @onlywei!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@onlywei onlywei changed the title Add "resolveSharedConfigsRelativeTo" config option feat: Add "resolveSharedConfigsRelativeTo" config option May 9, 2024
@mdjermanovic
Copy link
Member

The eslintrc config system is deprecated, so we're not making any further changes to it.

Note that extends also accepts absolute paths, so you could do something like this:

// .eslintrc.js

const Module = require("module");
const path = require("path");

const requireFromCentralLinter = Module.createRequire(path.resolve("repotools", "central-linter", "_.js"));

module.exports = {
    extends: [requireFromCentralLinter.resolve("eslint-config-example")] // extends eslint-config-example installed in repotools/central-linter/node_modules
};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

None yet

2 participants