Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Require eslint:all and eslint:recommended as parameters. #103

Merged
merged 3 commits into from Feb 21, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Feb 20, 2023

Switches FlatCompat to require configs for eslint:recommended and eslint:all to be passed in as parameters.

  • Adds allConfig and recommendedConfig as parameters to FlatCompat constructor
  • Throws an error if eslint:recommended or eslint:all are extended without defining recommendedConfig or allConfig, respectively.

Refs eslint/eslint#16844

Should be released before eslint/eslint#16844 is released.

@mdjermanovic
Copy link
Member

There's a lint error.

lib/flat-compat.js Outdated Show resolved Hide resolved
@nzakas
Copy link
Member Author

nzakas commented Feb 21, 2023

Thanks.

We should really get around to setting up the rest of the repos the same as ESLint. I thought we have an eslint precommit hook here but apparently not.

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdjermanovic mdjermanovic merged commit 013bdf3 into main Feb 21, 2023
@mdjermanovic mdjermanovic deleted the extern-recommended branch February 21, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants